refactor: Dropping Jax from scvi-tools#3786
Open
ori-kron-wis wants to merge 5 commits into
Open
Conversation
ori-kron-wis
added
jax
on-merge: backport to 1.4.x
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
==========================================
- Coverage 88.52% 84.69% -3.84%
==========================================
Files 237 237
Lines 23827 23387 -440
==========================================
- Hits 21094 19808 -1286
- Misses 2733 3579 +846
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21296cc828
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
|
We will need to transform Tangram to Torch before we remove Jax. Afterwards it will also move to scviva-tools @canergen |
# Conflicts: # .github/workflows/test_linux_nonjax.yml # pyproject.toml # src/scvi/external/tangram/_model.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.